Skip to content

[Re] zephyrSerial: Fix misdetection arduino_serial1 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2023
Merged

[Re] zephyrSerial: Fix misdetection arduino_serial1 #81

merged 1 commit into from
Aug 29, 2023

Conversation

soburi
Copy link
Member

@soburi soburi commented Aug 28, 2023

Repush #79 changes to merge.

@soburi
zephyrSerial: Fix misdetection arduino_serial1
1fac852 
DT_NODE_EXISTS value is true even if the status is disabled,
so it caused misdetection.
Use DT_NODE_HAS_STATUS to detect the status of
the arduino_serial1 node is ok.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
@soburi
Copy link
Member Author

soburi commented Aug 28, 2023

@DhruvaG2000

@DhruvaG2000 DhruvaG2000 self-requested a review August 29, 2023 01:23
@DhruvaG2000
Copy link
Collaborator

Thanks for the sign off,
checkpatch seems happy!

 08:43:05 Arduino-Zephyr-API on  re-correct_arduino_serial1 ➜ ../../../zephyr/scripts/checkpatch.pl -g --strict HEAD
total: 0 errors, 0 warnings, 0 checks, 16 lines checked

Commit 1fac852d466f ("zephyrSerial: Fix misdetection arduino_serial1") has no obvious style problems and is ready for submission.

NOTE: Ignored message types: COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES NEW_TYPEDEFS SPDX_LICENSE_TAG

@DhruvaG2000 DhruvaG2000 merged commit b715281 into zephyrproject-rtos:next Aug 29, 2023
@soburi soburi deleted the re-correct_arduino_serial1 branch August 29, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhruvaG2000 DhruvaG2000 DhruvaG2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soburi @DhruvaG2000